[DO-NOT-MERGE] Latest paradox deps test #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
commented
Feb 14, 2024
| @@ -0,0 +1,8 @@ | |||
| addSbtPlugin("com.lightbend.paradox" % "sbt-paradox" % "0.10.6") | |||
There was a problem hiding this comment.
This is the important part, as you can see we are loading the most recent version of sbt-paradox/sbt-paradox-theme
This was referenced Feb 14, 2024
Closed
|
Closing PR since it was just a demonstration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just here to demonstrate what is said here, specifically that even though sbt-paradox-material-theme may be compiled against sbt-paradox/sbt-paradox-theme 0.9.2, it will work completely fine with sbt-paradox/sbt-paradox-theme 0.10.6
In order to demonstrate this, check out the PR's branch and make sure to set JDK to 11 (since sbt-paradox/sbt-paradox-theme 0.10.6 only supports JDK 11+) and run the following command
Ideally we would actually add this as a scripted test to the repo but unfortunately there isn't an easy way to do this since the rest of the tests only run on JDK 8 and this scripted test needs to be run with JDK 11 specifically (this is why the CI is failing)